fix(devtools): DOM traversal bug #62719
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksanderBodurri
changed the title
AleksanderBodurri
force-pushed
the
fix-traversal
branch
from
42ade78 to
2e5e2c5
Compare
AleksanderBodurri
force-pushed
the
fix-traversal
branch
from
2e5e2c5 to
bcd4a54
Compare
| @@ -92,30 +92,6 @@ describe('render tree extraction', () => { | |||
| expect(rtree[0].children[0].children.length).toBe(0); | |||
| }); | |||
|
|
|||
| it('should go all the way to the root element to look up for nodes', () => { | |||
There was a problem hiding this comment.
The logic to traverse up to the DOM is no longer the responsibility of RTree strategy so this test is no longer necessary.
The new behaviour is now tested for in devtools/cypress/integration/node-search.e2e.js.
AleksanderBodurri
force-pushed
the
fix-traversal
branch
from
bcd4a54 to
e9685f3
Compare
JeanMeche
reviewed
Jul 20, 2025
devtools/projects/ng-devtools-backend/src/lib/component-tree/component-tree.ts
Show resolved
Hide resolved
JeanMeche
reviewed
Jul 20, 2025
devtools/projects/ng-devtools-backend/src/lib/directive-forest/index.ts
Outdated
Show resolved
Hide resolved
AleksanderBodurri
force-pushed
the
fix-traversal
branch
2 times, most recently
from
cec7d4d to
2f3278e
Compare
JeanMeche
reviewed
Jul 21, 2025
AleksanderBodurri
force-pushed
the
fix-traversal
branch
2 times, most recently
from
27f7703 to
82192b9
Compare
dgp1130
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
This seems like a good step in the right direction, so I think it's fine to move forward with this PR. I suspect there might be a future change we should consider in the framework so ApplicationRef actually has correct knowledge of all the root views in an application so we don't need to do this work in DevTools at all.
devtools/projects/ng-devtools-backend/src/lib/component-tree/component-tree.ts
Show resolved
Hide resolved
devtools/projects/ng-devtools-backend/src/lib/component-tree/component-tree.ts
Show resolved
Hide resolved
devtools/projects/ng-devtools-backend/src/lib/directive-forest/index.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools-backend/src/lib/directive-forest/index.ts
Outdated
Show resolved
Hide resolved
thePunderWoman
added
target: minor
AleksanderBodurri
force-pushed
the
fix-traversal
branch
2 times, most recently
from
4d3cf76 to
740f871
Compare
dgp1130
approved these changes
Aug 12, 2025
devtools/projects/ng-devtools-backend/src/lib/component-tree/component-tree.ts
Show resolved
Hide resolved
devtools/projects/ng-devtools-backend/src/lib/component-tree/component-tree.ts
Outdated
Show resolved
Hide resolved
| return []; | ||
| } | ||
|
|
||
| return strategy.build(element, i++); |
There was a problem hiding this comment.
Consider: I think flatMap provides an index argument you can use instead of tracking i++ directly.
You might want to flatMap element to [element, strategy] first to handle the !strategy case first:
elements.flatMap((element) => {
const strategy = selectStrategy(element);
if (!strategy) return [];
return [element, strategy];
}).map(([element, strategy], index) => strategy.build(element, index));There was a problem hiding this comment.
Returning an array from the map causes weird things to occur with the typing of element and strategy. They both end up being treated as RTreeStrategy | LTreeStrategy | Element. I think the current approach is sufficient to avoid this
AleksanderBodurri
force-pushed
the
fix-traversal
branch
3 times, most recently
from
dbc3524 to
0c7fe11
Compare
Previously, Angular devtools would mistakenly traverse the same DOM elements multiple times while doing traversal for the component tree explorer. This error case would occur when more than 1 Angular application root component was present on the same page and in distinct DOM branches. Some example cases that did work previously: ```html <app-root> ... </app-root> ``` ```html <app-root> ... <app-root-2></app-root-2> ... </app-root> ``` An example of where it would enter the irregular behaviour ```html <app-root> ... </app-root> <app-root-2> ... </app-root-2> ``` Now, we properly ignore duplicate DOM paths when looking for application and non-application root component to begin the Angular DevTools component discovery logic.
AleksanderBodurri
force-pushed
the
fix-traversal
branch
from
0c7fe11 to
4cc57d5
Compare
AleksanderBodurri
added
action: review
AleksanderBodurri
added
action: merge
thePunderWoman
added
target: rc
thePunderWoman
pushed a commit
that referenced
this pull request
Aug 18, 2025
Previously, Angular devtools would mistakenly traverse the same DOM elements multiple times while doing traversal for the component tree explorer. This error case would occur when more than 1 Angular application root component was present on the same page and in distinct DOM branches. Some example cases that did work previously: ```html <app-root> ... </app-root> ``` ```html <app-root> ... <app-root-2></app-root-2> ... </app-root> ``` An example of where it would enter the irregular behaviour ```html <app-root> ... </app-root> <app-root-2> ... </app-root-2> ``` Now, we properly ignore duplicate DOM paths when looking for application and non-application root component to begin the Angular DevTools component discovery logic. PR Close #62719
|
This PR was merged into the repository by commit 5115050. The changes were merged into the following branches: main, 20.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Angular devtools would mistakenly traverse the same DOM elements multiple times while doing traversal for the component tree explorer. This error case would occur when more than 1 Angular application root component was present on the same page and in distinct DOM branches.
An example of where it would enter the irregular behaviour (previous state)
Now, we properly ignore duplicate DOM paths when looking for application and non-application root component to begin the Angular DevTools component discovery logic.