Skip to content

Firebase 5.10 timestampInSnapshots error #2050

@ron4548

Description

@ron4548

Version info

Angular: 7.2.13

Firebase: 5.10.0

AngularFire: 5.1.2

Other (e.g. Ionic/Cordova, Node, browser, operating system):

How to reproduce these conditions

Just use the AngularFireStore module with the specified versions, and the error appears.

Debug output

index.esm.js:78 [2019-04-20T17:18:20.735Z]  @firebase/firestore: Firestore (5.10.0): 
  The timestampsInSnapshots setting now defaults to true and you no
  longer need to explicitly set it. In a future release, the setting
  will be removed entirely and so it is recommended that you remove it
  from your firestore.settings() call now.

image

Expected behavior

Error should not be displayed according to the following line (firestore.ts:22):
export const DefaultFirestoreSettings = (parseFloat(SDK_VERSION) < 5.8 ? {timestampsInSnapshots: true} : {}) as Settings;
https://github.com/angular/angularfire2/blob/master/src/firestore/firestore.ts

Actual behavior

Since the version is parsed to a float, version 5.10 is considered as 5.1 and therefore the timestampsInSnapshots setting is enabled explicitly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions