Angularfire2 Ionic2 facebook auth error

[theunreal]

Version info

Angular: 2.2.1

**Firebase:**3

**AngularFire:**beta 6

Other (e.g. Ionic/Cordova, Node, browser, operating system): Ionic 2 RC.4 - Cordova Android

Steps to set up and reproduce

signInWithFacebook(): firebase.Promise<FirebaseAuthState> {
    if (this.platform.is('cordova')) {
      console.log("trying to log in using cordova...");
      Facebook.login(['email', 'public_profile']).then(res => {
        console.log("Logged in. result here");
        const facebookCredential = firebase.auth.FacebookAuthProvider.credential(res.authResponse.accessToken);
        console.log(firebase.auth().signInWithCredential(facebookCredential));
        return firebase.auth().signInWithCredential(facebookCredential);
      });
    } else {
      return this.auth$.login({
        provider: AuthProviders.Facebook,
        method: AuthMethods.Popup
      });
    }
  }

Debug output

** Errors in the JavaScript console **

The app works great in web browser. In Android, the login doese't work.
I debugged why the login button is not working and I found this errors:

EXCEPTION: Error in ./HomePage class HomePage - inline template:6:0 caused by: Cannot read property 'then' of undefined....

Logged in. result here

EXCEPTION: Uncaught (in promise): ReferenceError: firebase is not defined
ReferenceError: firebase is not defined
    at file:///android_asset/www/build/main.js:42039:42
    at t.invoke...

I tried to: console.log(this._auth.signInWithFacebook()); and it returned undefined.

Regards the second issue (firebase is not defined) I tried to
import firebase from 'firebase';
but Ionic 2 build returned error.

Expected behavior

Facebook login work on Android (Cordova)

Actual behavior

Login button return errors as described above

[utkukaynar]

Dear @theunreal, did you solve this problem? I'm having the exact same issue on iOS.

[lickos]

Dear @theunreal, did you solve this problem? I'm having the exact same issue on Android.

[theunreal]

@utkukaynar @lickos return the Facebook.login...

[utkukaynar]

Didn't update this issue. I realized it and updated the documentation with a merged pr. Utku Kaynar iPhone'umdan gönderildi Eliran Elnasi <notifications@github.com> şunları yazdı (29 Ara 2016 15:29):

…

@utkukaynar @lickos return the Facebook.login... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[lickos]

@theunreal
I did it.
return Facebook.login(['email', 'public_profile']).then(res => {....
I got this error:
Type 'Promise"FacebookLoginResponse"' is not assignable to type 'Promise"FirebaseAuthState"'.at line 25 col 14

[utkukaynar]

Here's my working code :

      return Facebook.login(['email', 'public_profile']).then(res => {
        const facebookCredential = firebase.auth.FacebookAuthProvider.credential(res.authResponse.accessToken);
        return firebase.auth().signInWithCredential(facebookCredential);
      });

[dhruv4]

I'm still having this issue, although I used the code that @utkukaynar gave us. I'm getting the same issue that @lickos has and, while the Facebook auth is popping up, the login process isn't actually occurring through Firebase. I'm getting the error message: firebase is not defined.

[lickos]

@utkukaynar
I copied and pasted your code. Still same problem.
Type 'Promise"FacebookLoginResponse"' is not assignable to type 'Promise"FirebaseAuthState"
I don't know what i am missing

[lickos]

When i run it on the emulator with livereloads i get this error:
Typescript error.
Duplicate identifire 'Promise'

[utkukaynar]

Can you paste your latest function block of code in here? Utku Kaynar iPhone'umdan gönderildi lickos <notifications@github.com> şunları yazdı (30 Ara 2016 10:01):

…

When i run it on the emulator with livereloads i get this error: Typescript error. Duplicate identifire 'Promise' — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[lickos]

@utkukaynar
signInWithFacebook(): firebase.Promise<FirebaseAuthState> { if (this.platform.is('cordova')) { return Facebook.login(['email', 'public_profile']).then(res => { const facebookCredential = firebase.auth.FacebookAuthProvider.credential(res.authResponse.accessToken); return firebase.auth().signInWithCredential(facebookCredential); }); } else { return this.auth$.login({ provider: AuthProviders.Facebook, method: AuthMethods.Popup }); } }

[lickos]

@utkukaynar
These are my imports:
import { Injectable } from '@angular/core'; import { AuthProviders, FirebaseAuth, FirebaseAuthState, AuthMethods } from 'angularfire2'; import { Platform } from 'ionic-angular'; import { Facebook } from 'ionic-native';

What am I missing?
By the way Happy new Year to all of you

[lickos]

@utkukaynar
I also tried this:
signInWithFacebook(): firebase.Promise<FirebaseAuthState> { if (this.platform.is('cordova')) { Facebook.login(['email', 'public_profile']).then(res => { alert("this") let provider = new firebase.auth.FacebookAuthProvider(); alert("That") // alert(provider); // const facebookCredential = provider.credential(res.authResponse.accessToken); return firebase.auth().signInWithRedirect(provider); }); } else { return this.auth$.login({ provider: AuthProviders.Facebook, method: AuthMethods.Popup }); } }

But still firebase is not defined

[utkukaynar]

can you add this? I didn't and mine is working but some people got it working with this fix :

import { firebase } from 'firebase';