Skip to content

Conversation

jofftiquez
Copy link
Contributor

Just a little bit typo

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • e2e tests included?: (yes/no; required for multi-function/multi-class changes)
  • In a clean directory, npm install, npm run build, and npm test run successfully? (yes/no; required)

Description

Code sample

Just a little bit typo
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Copy link
Contributor

@markgoho markgoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jofftiquez

@markgoho
Copy link
Contributor

markgoho commented Jun 2, 2017

@jofftiquez make sure you sign the CLA and then reply back here that you've done it. I don't think the PR can be merged without it.

@jamesdaniels jamesdaniels merged commit 0972188 into angular:master Jun 2, 2017
@jofftiquez
Copy link
Contributor Author

@markgoho done. thanks! :)

@jofftiquez jofftiquez deleted the patch-1 branch June 6, 2017 14:20
@jofftiquez jofftiquez changed the title Corrected typo chore: fix typo Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants