Skip to content

chore(build): we aren't prefixing tags with 'v' #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2019
Merged

chore(build): we aren't prefixing tags with 'v' #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apt-get -y install rsync
yarn

if test $TAG_NAME; then
export VERSION=$(echo $TAG_NAME | sed 's/^v\(.*\)$/\1/')
export VERSION=$TAG_NAME
else
export VERSION=$(npm version | head -n 1 | sed "s/^.*: '\([^']*\).*/\1/")-canary.$SHORT_SHA
fi
Expand Down
8 changes: 4 additions & 4 deletions tools/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > ~/.npmrc
cd dist/packages-dist

LATEST_TEST="^v[^-]*$"
PRODUCTION_TEST="^[^-]*$"

if test $TAG_NAME; then
if [[ ! $TAG_NAME =~ $LATEST_TEST ]]; then
npm publish . --tag next
else
if [[ $TAG_NAME =~ $PRODUCTION_TEST ]]; then
npm publish . &&
cd ../wrapper-dist &&
npm publish . &&
npm deprecate angularfire2 "AngularFire has moved, we're now @angular/fire"
else
npm publish . --tag next
fi
else
npm publish . --tag canary
Expand Down