fix: auth settings setter instead of ovewriting readonly object #2833

KingDarBoja · 2021-05-17T16:37:42Z

Issue number for this PR: Uncaught TypeError: Cannot assign to read only property 'settings' of object '[object Object]' #2826
Docs included?: no
Test units included?: yes
In a clean directory, yarn install, yarn test run successfully? yes

Instead of assigning to the auth settings readonly object, assign directly the property appVerificationDisabledForTesting.

jamesdaniels

Looks good, thanks for the fix. See nit

src/auth/auth.ts

jamesdaniels

LGTM, prepping the next release this evening. Will include.

fix: auth settings setter instead of ovewriting readonly object

1406fd8

google-cla bot added the cla: yes label May 17, 2021

jamesdaniels requested changes May 17, 2021

View reviewed changes

src/auth/auth.ts Outdated Show resolved Hide resolved

misc: loop over each auth setting for future options

c7539aa

jamesdaniels approved these changes May 18, 2021

View reviewed changes

jamesdaniels merged commit 984803d into angular:master May 18, 2021

KingDarBoja deleted the fix/auth-settings branch May 18, 2021 13:22

Provide feedback