Skip to content

Fix properties in deploy schema that require oneOf #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Fix properties in deploy schema that require oneOf #3092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/schematics/deploy/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"pattern": "^[^:\\s]+:[^:\\s]+(:[^\\s]+)?$"
},
"ssr": {
"type": ["boolean", "string"],
"oneOf": [{ "type": "boolean" }, { "type": "string" }],
"description": "Should we attempt to deploy the function to Cloud Functions (true or 'cloud-functions') / Cloud Run ('cloud-run') or just Hosting (false)"
},
"prerender": {
Expand All @@ -54,7 +54,7 @@
"description": "The name of the Cloud Function or Cloud Run serviceId to deploy SSR to"
},
"functionsNodeVersion": {
"type": ["number", "string"],
"oneOf": [{ "type": "number" }, { "type": "string" }],
"description": "Version of Node.js to run Cloud Functions / Run on"
},
"region": {
Expand Down Expand Up @@ -82,12 +82,12 @@
"description": "Set a CPU limit in Kubernetes cpu units."
},
"maxConcurrency": {
"type": ["number", "string"],
"oneOf": [{ "type": "number" }, { "type": "string" }],
"pattern": "^(\\d+|default)$",
"description": "Set the maximum number of concurrent requests allowed per container instance. If concurrency is unspecified, any number of concurrent requests are allowed. To unset this field, provide the special value default."
},
"maxInstances": {
"type": ["number", "string"],
"oneOf": [{ "type": "number" }, { "type": "string" }],
"pattern": "^(\\d+|default)$",
"description": "The maximum number of container instances of the Service to run. Use 'default' to unset the limit and use the platform default."
},
Expand All @@ -97,7 +97,7 @@
"description": "Set a memory limit. Ex: 1Gi, 512Mi."
},
"minInstances": {
"type": ["number", "string"],
"oneOf": [{ "type": "number" }, { "type": "string" }],
"pattern": "^(\\d+|default)$",
"description": "The minimum number of container instances of the Service to run or 'default' to remove any minimum."
},
Expand Down