feat(schematics): ng deploy schematic #2046

jamesdaniels · 2019-04-18T02:04:25Z

Checklist

Issue number for this PR: #nnn (required)
Docs included?: (yes/no; required for all API/functional changes)
Test units included?: (yes/no; required)
In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

add schematic, which logs the user in with the Firebase CLI and has them choose a project
deploy schematic, deploys their application to Firebase Hosting using the CLI
bumping versions, to allow use with ng 8 (and thinking forward to 9 rcs)

Usage

ng add @angular/fire
ng run [PROJECT_NAME]:deploy

googlebot · 2019-04-18T02:04:29Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-04-18T02:04:32Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

jamesdaniels · 2019-04-18T02:07:14Z

FYI @kirjs I rearranged things a bit and got it compiling. Haven't tested yet. Have a couple more cleanup tasks.

kirjs · 2019-04-18T18:31:40Z

Cool, lmk if there's any way I can help

jamesdaniels · 2019-04-18T19:33:42Z

@kirjs I'll ping you after my testing this afternoon.

My main concern is depending on firebase-tools it will light up npm audit, as it has vulnerabilities (mostly due to needing to support Node 6 for at least the next couple weeks). Fine with me if it's an @next cut. If we do pull into prod release, we'll want standard coms for it being a development dep (and maybe peer it) or to wait until firebase-tools drops Node 6... though perhaps the management APIs can give us what we need. Thoughts @davideast?

jamesdaniels · 2019-04-18T19:47:01Z

@kirjs in the meantime, feel free to check out getting your tests ported. I just killed them for the moment but I put placeholders in... place.

Make sure everything works 🔥

jamesdaniels · 2019-05-20T20:08:41Z

@jhuleatt if you could give this a quick look over so we can merge it would be appreciated. It's had a bunch of eyeballs on it between myself, @kirjs, and @mgechev so the risk is low (beyond my prior expressed general concerns) so feel free to rubber stamp if nothing smells funny to you.

docs/deploy/getting-started.md

jhuleatt · 2019-05-21T23:07:28Z

docs/deploy/getting-started.md

+
+*Note that the command above assumes you have global Angular CLI installed. To install Angular CLI globally run `npm i -g @angular/cli`.*
+
+The command above will trigger the `@angular/fire` `ng-add` schematics. Once they install `@angular/fire`. If you are not authenticated, the schematics will open a browser which will guide you through the authentication flow. Once you authenticate, you'll see a prompt to select a Firebase hosting project.


When I ran ng-add, the "choose a project" prompt wasn't in alphabetical order. The Firebase CLI returns them in alphabetical, so that was unexpected for me. Probably not a huge deal since most people don't have tons of projects, but worth fixing if it isn't a ton of work.

For convenience, we provide fuzzy search. Maybe alphabetical order will be an additional simplification. We can add this.

docs/deploy/getting-started.md

jhuleatt

I've left a couple of documentation comments, but overall, LGTM!

mgechev · 2019-05-22T12:42:03Z

Just opened a PR (#2081) to address @jhuleatt's comments.

googlebot · 2019-05-22T21:56:31Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-05-22T21:56:31Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-05-22T22:15:46Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-05-22T22:15:46Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-05-22T22:17:17Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-05-22T22:17:17Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

kirjs and others added 2 commits April 10, 2019 18:15

Add ng-deploy

1445f28

Rearranging the schematics a bit

1d5dcd2

googlebot added the cla: no label Apr 18, 2019

jamesdaniels and others added 7 commits April 24, 2019 13:57

Cleaning some stuff up, still having spec issues

125cc13

Set up builder/schematic in package.json (#2053)

b36f972

Make sure everything works 🔥

Build the schematics as UMD, so we can test

524be38

Merge branch 'master' into feature/ng-deploy

2dd5362

Drop the compileSchematics build step

5c23777

Target es6 & commonjs

fdde4d7

@angular/fire:deploy, not ng-deploy

72da1b1

jamesdaniels mentioned this pull request Apr 25, 2019

feat(schematics): ng-add schematics #1853

Closed

jamesdaniels added the pr_state: WIP label Apr 25, 2019

jamesdaniels added this to the 5.2.0 milestone Apr 25, 2019

mgechev and others added 3 commits April 28, 2019 17:03

test: add specs for ng deploy firebase (#2054)

a72c3f7

Add node tests to travis

fc6f869

docs: add docs for the deployment capabilities (#2056)

5c962cc

jamesdaniels requested a review from jhuleatt April 30, 2019 02:23

jamesdaniels requested a review from davideast May 20, 2019 00:46

jamesdaniels added 2 commits May 19, 2019 22:49

Merged master.

c547b4e

Bumping versions

c940a82

jamesdaniels changed the title ~~WIP deploy schematic~~ feat(schematics): ng deploy schematic May 20, 2019

jamesdaniels added 2 commits May 20, 2019 00:00

Deploy getting started to replace old guide

b666254

Bad npm command

4292cdd

jamesdaniels assigned jhuleatt May 20, 2019

jhuleatt requested changes May 21, 2019

View reviewed changes

jhuleatt reviewed May 21, 2019

View reviewed changes

docs/deploy/getting-started.md Outdated Show resolved Hide resolved

jhuleatt approved these changes May 22, 2019

View reviewed changes

mgechev and others added 2 commits May 22, 2019 14:49

refactor: update documentation & improve error messages (#2081)

3a1b108

Merged master.

4adc1f6

jamesdaniels added cla: yes and removed cla: no labels May 22, 2019

Fix the node test and clean up build output

c709f04

googlebot added cla: no and removed cla: yes labels May 22, 2019

jamesdaniels added cla: yes and removed cla: no pr_state: WIP labels May 22, 2019

jamesdaniels merged commit be0a1fb into master May 22, 2019

jamesdaniels deleted the feature/ng-deploy branch May 22, 2019 22:27

jamesdaniels mentioned this pull request May 24, 2019

Discussion: 5.2 release #2086

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(schematics): ng deploy schematic #2046

feat(schematics): ng deploy schematic #2046

jamesdaniels commented Apr 18, 2019 •

edited

googlebot commented Apr 18, 2019

googlebot commented Apr 18, 2019

jamesdaniels commented Apr 18, 2019

kirjs commented Apr 18, 2019

jamesdaniels commented Apr 18, 2019 •

edited

jamesdaniels commented Apr 18, 2019

jamesdaniels commented May 20, 2019

jhuleatt May 21, 2019

mgechev May 22, 2019

jhuleatt left a comment

mgechev commented May 22, 2019

googlebot commented May 22, 2019

googlebot commented May 22, 2019

googlebot commented May 22, 2019

googlebot commented May 22, 2019

googlebot commented May 22, 2019

googlebot commented May 22, 2019


		Note that the command above assumes you have global Angular CLI installed. To install Angular CLI globally run `npm i -g @angular/cli`.

		The command above will trigger the `@angular/fire` `ng-add` schematics. Once they install `@angular/fire`. If you are not authenticated, the schematics will open a browser which will guide you through the authentication flow. Once you authenticate, you'll see a prompt to select a Firebase hosting project.

feat(schematics): ng deploy schematic #2046

feat(schematics): ng deploy schematic #2046

Conversation

jamesdaniels commented Apr 18, 2019 • edited

Checklist

Description

Usage

googlebot commented Apr 18, 2019

googlebot commented Apr 18, 2019

jamesdaniels commented Apr 18, 2019

kirjs commented Apr 18, 2019

jamesdaniels commented Apr 18, 2019 • edited

jamesdaniels commented Apr 18, 2019

jamesdaniels commented May 20, 2019

jhuleatt May 21, 2019

Choose a reason for hiding this comment

mgechev May 22, 2019

Choose a reason for hiding this comment

jhuleatt left a comment

Choose a reason for hiding this comment

mgechev commented May 22, 2019

googlebot commented May 22, 2019

googlebot commented May 22, 2019

googlebot commented May 22, 2019

googlebot commented May 22, 2019

googlebot commented May 22, 2019

googlebot commented May 22, 2019

jamesdaniels commented Apr 18, 2019 •

edited

jamesdaniels commented Apr 18, 2019 •

edited