fix(database): store unwrapped snapshots #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
changed the title
Store either unwrapped snapshots or preserved snapshots; don't store preserved snapshots and call utils.unwrapMapFn when emitting. Closes angular#791
This was referenced Apr 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store either unwrapped snapshots or preserved snapshots; don't store
preserved snapshots and call utils.unwrapMapFn when emitting.
Closes #791
Checklist
npm install,npm run build, andnpm testrun successfully? yesDescription
Fixes #791. The
FirebaseListObservable's internal array now stores either snapshots or unwrapped snapshots depending upon thepreserveSnapshotoption. Between emissions, unchanged elements now refer to the same object instances - which should see significant performance improvements when using Angular'sOnPushchange detection strategy.