fix: fall back to darwin_x64 if available on darwin_arm64 #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprobst
reviewed
Dec 11, 2020
index.js
Outdated
| 'Consider installing it with your native package manager instead.\n'; | ||
| throw new Error(message); | ||
| if (platform === 'darwin' && arch === 'arm64') { |
There was a problem hiding this comment.
maybe we could write this a little less repetitively?
E.g.
if (existsSync(nativeBinary)) return nativeBinary;
if (darwin && arm64) { check if darwin_x64 exists, return if so }
construct error message and throw
That'd avoid the duplicate throw, and also move all error msg construction and handling after the positive paths.
There was a problem hiding this comment.
@mprobst Ok, I've force-pushed a new commit which is a little cleaner and follows the early return suggestion here.
sgtcoolguy
force-pushed
the
darwin-arm64-fallback
branch
from
dde3a06 to
49b2fde
Compare
mprobst
approved these changes
Dec 14, 2020
|
Thanks! |
|
Released in 1.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fallback mechanism. There's no
Darwin_arm64binary built here yet, so on those machines this will fall back to theDarwin_x64binary if available (which it is). Works for me locally on a new macMini M1.