Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hideRequiredMarker to MatFormFieldDefaultOptions #16243

Closed
jermowery opened this issue Jun 10, 2019 · 1 comment · Fixed by #16244
Closed

Add hideRequiredMarker to MatFormFieldDefaultOptions #16243

jermowery opened this issue Jun 10, 2019 · 1 comment · Fixed by #16244
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@jermowery
Copy link
Contributor

Feature Description

Please add an option to MatFormFieldDefaultOptions to hide the required marker on the field.
This will allow us to default all form fields to hide the required marker instead of specifying the hideRequiredMarker input on each one. Add the field to MatFormFieldDefaultOptions and default the value of the hideRequiredMarker input of MatFormField this this value (I think this is trivial)

Use Case

In our app our UX team wants all fields required by default, so the required marker is overkill. We have to specify hideRequiredMarker on every single usage of MatFormField which is tedious and becomes error prone. Add this feature would eliminate this issue for us.

@jermowery jermowery added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Jun 10, 2019
@crisbeto crisbeto self-assigned this Jun 10, 2019
@crisbeto crisbeto added G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Jun 10, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 10, 2019
…ured

Allows for the `hideRequiredMarker` default value to be configured through the `MAT_FORM_FIELD_DEFAULT_OPTIONS` injection token.

Fixes angular#16243.
mmalerba pushed a commit that referenced this issue Aug 13, 2019
Allows for the `hideRequiredMarker` default value to be configured through the `MAT_FORM_FIELD_DEFAULT_OPTIONS` injection token.

Fixes #16243.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants