bug[mat-icon] unreachable code result from possible spell miss

[chigix]

components/src/material/icon/icon.ts

Line 256 in 65e9ad1

} else if (svgIconChanges.previousValue) {

Because previousValue is accessible on the SimpleChanges event object rather than the svgIconChanges that is obtained from changes['svgIcon'], the line

components/src/material/icon/icon.ts

Line 256 in 65e9ad1

} else if (svgIconChanges.previousValue) {

becomes unreachable at present.

Please confirm is it an intended design or just a bug ?

If it is a bug, would it be a necessity to update testing cases in spec files to reflect this corresponding conditional branch ?

[crisbeto]

I'm not sure I follow what the issue is here. The svgIconChanges is a SimpleChange object that contains the current and previous value for the svgIcon input. That being said, we aren't even using ngOnChanges after #20509 so this code doesn't exist anymore.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}