Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(mat-select): Standard appearance select's ripple is not visible in high contrast mode #21780

Closed
dwaynelavon opened this issue Feb 2, 2021 · 1 comment · Fixed by #21805
Closed

bug(mat-select): Standard appearance select's ripple is not visible in high contrast mode #21780

dwaynelavon opened this issue Feb 2, 2021 · 1 comment · Fixed by #21805
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) area: material/form-field P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@dwaynelavon
Copy link

Reproduction

Stackblitz: https://stackblitz.com/edit/angular-lh4cau?file=src/app/select-overview-example.html

Steps to reproduce:

  1. Turn on high contrast mode
  2. Open Stackblitz and tab to the mat-select

Expected Behavior

What behavior were you expecting to see?
Focus ripple should be visible.

Actual Behavior

What behavior did you actually see?
Focus ripple is not visible. Only seems to be an issue with appearance="standard". Legacy works fine

Environment

  • Angular: 11.0.3
  • CDK/Material: 11.0.3
  • Browser(s): Firefox
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows with High Contrast Mode
@dwaynelavon dwaynelavon added the needs triage This issue needs to be triaged by the team label Feb 2, 2021
@crisbeto crisbeto self-assigned this Feb 4, 2021
@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) area: material/form-field has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Feb 4, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 4, 2021
@crisbeto
fix(material/form-field): focus indication not working for standard a…
fd5b15f 
…ppearance in high contrast mode

There was a syntax error which prevented the focus indication from rendering
in high contrast mode.

Fixes angular#21780.
@crisbeto crisbeto mentioned this issue Feb 4, 2021
Merged
annieyw pushed a commit that referenced this issue Feb 9, 2021
@crisbeto
fix(material/form-field): focus indication not working for standard a…
0484310 
…ppearance in high contrast mode (#21805)

There was a syntax error which prevented the focus indication from rendering
in high contrast mode.

Fixes #21780.
annieyw pushed a commit that referenced this issue Feb 9, 2021
@crisbeto @annieyw
fix(material/form-field): focus indication not working for standard a…
fdce96d 
…ppearance in high contrast mode (#21805)

There was a syntax error which prevented the focus indication from rendering
in high contrast mode.

Fixes #21780.

(cherry picked from commit 0484310)
annieyw pushed a commit that referenced this issue Feb 9, 2021
@crisbeto @annieyw
fix(material/form-field): focus indication not working for standard a…
fd7c2ea 
…ppearance in high contrast mode (#21805)

There was a syntax error which prevented the focus indication from rendering
in high contrast mode.

Fixes #21780.

(cherry picked from commit 0484310)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) area: material/form-field P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @dwaynelavon