Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/form-field): focus indication not working for standard appearance in high contrast mode #21805

Merged
merged 1 commit into from
Feb 9, 2021
Merged

fix(material/form-field): focus indication not working for standard appearance in high contrast mode #21805

merged 1 commit into from
Feb 9, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 4, 2021

There was a syntax error which prevented the focus indication from rendering in high contrast mode.

Fixes #21780.

@crisbeto
fix(material/form-field): focus indication not working for standard a…
fd5b15f 
…ppearance in high contrast mode

There was a syntax error which prevented the focus indication from rendering
in high contrast mode.

Fixes angular#21780.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Feb 4, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 4, 2021
mmalerba
mmalerba approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 4, 2021
@annieyw annieyw merged commit 0484310 into angular:master Feb 9, 2021
annieyw pushed a commit that referenced this pull request Feb 9, 2021
@crisbeto @annieyw
fix(material/form-field): focus indication not working for standard a…
fdce96d 
…ppearance in high contrast mode (#21805)

There was a syntax error which prevented the focus indication from rendering
in high contrast mode.

Fixes #21780.

(cherry picked from commit 0484310)
annieyw pushed a commit that referenced this pull request Feb 9, 2021
@crisbeto @annieyw
fix(material/form-field): focus indication not working for standard a…
fd7c2ea 
…ppearance in high contrast mode (#21805)

There was a syntax error which prevented the focus indication from rendering
in high contrast mode.

Fixes #21780.

(cherry picked from commit 0484310)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-select): Standard appearance select's ripple is not visible in high contrast mode
3 participants
@crisbeto @mmalerba @annieyw