Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum required Sass version and remove private polyfills #22915

Closed
crisbeto opened this issue Jun 7, 2021 · 1 comment · Fixed by #23414
Closed

Update minimum required Sass version and remove private polyfills #22915

crisbeto opened this issue Jun 7, 2021 · 1 comment · Fixed by #23414
Assignees
@crisbeto
Labels
area: material/core P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone
13.0.0

Comments

@crisbeto
Copy link
Member

crisbeto commented Jun 7, 2021

We should communicate that the minimum required version of Sass is 1.34.0 and remove the private-div and private-slash helpers that were introduced by #22871.

Has to be done in the next major release.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround blocked This issue is blocked by some external factor, such as a prerequisite PR labels Jun 7, 2021
@crisbeto crisbeto added this to the 13.0.0 milestone Jun 7, 2021
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P2 The issue is important to a large percentage of users, with a workaround labels Jun 8, 2021
@crisbeto crisbeto self-assigned this Jun 8, 2021
@crisbeto crisbeto added area: material/core has pr and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Aug 20, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 20, 2021
@crisbeto
refactor(material/core): update minimum required sass version and cle…
fcebcef 
…an up workarounds

Updates the minimum required version of Sass and cleans up some workarounds for `list.slash` and `math.div`.

BREAKING CHANGE:
* Material now requires at least version 1.34.0 of Sass. Version 1.38.0 is recommended.

Fixes angular#22915.
@crisbeto crisbeto mentioned this issue Aug 20, 2021
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 20, 2021
@crisbeto
refactor(material/core): update minimum required sass version and cle…
f3cc88f 
…an up workarounds

Updates the minimum required version of Sass and cleans up some workarounds for `list.slash` and `math.div`.

BREAKING CHANGE:
* Material now requires at least version 1.34.0 of Sass. Version 1.38.0 is recommended.

Fixes angular#22915.
mmalerba pushed a commit that referenced this issue Aug 31, 2021
@crisbeto
refactor(material/core): update minimum required sass version and cle…
40f0674 
…an up workarounds (#23414)

Updates the minimum required version of Sass and cleans up some workarounds for `list.slash` and `math.div`.

BREAKING CHANGE:
* Material now requires at least version 1.34.0 of Sass. Version 1.38.0 is recommended.

Fixes #22915.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/core P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
13.0.0
1 participant
@crisbeto