fix(NativeDateAdapter): work around wrong javascript native Date-to-string conversions #10068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Feb 21, 2018
| * very frequently, and the current valid rule is not always valid in previous years though. | ||
| * We work around this problem building a new Date object which has its internal UTC | ||
| * representation with the local date and time. | ||
| * @param dtf Intl.DateTimeFormat object, containg the desired string format |
There was a problem hiding this comment.
Add a note that dtf must have its timeZone set to 'utc' for this method to work properly
|
Ok I tested Linux, Mac, and IE attempted to reproduce the issue described in #7167 (comment) and it seemed to work fine on all browser & OS's that I tested. So looks good |
mmalerba
added
pr: lgtm
action: merge
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Feb 26, 2018
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Feb 27, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like javascript messes things up when trying to apply DST rules to format some past dates during the Date-to-string conversions. The issue pops up when the past dates don't follow today's DST rules for a given locale (usually as a result of each local government decisions).