Skip to content

Conversation

crisbeto
Copy link
Member

Updates the bidi docs to mention that we only look at dir attributes inside of the user's app.

Relates to #10023.

…s within Angular

Updates the bidi docs to mention that we only look at `dir` attributes inside of the user's app.

Relates to angular#10023.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 21, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 21, 2018
@josephperrott josephperrott merged commit fe49345 into angular:master Feb 21, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Feb 27, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants