Skip to content

refactor(sidenav): remove 6.0.0 deletion targets #10279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 6, 2018

Removes the deletion targets for 6.0.0 from the material/drawer entry point.

BREAKING CHANGES:

  • The MatDrawerToggleResult class has been turned into an type.
  • The promise returned from open, close and toggle now resolves with the MatDrawerToggleResult type rather than the class.
  • align which was deprecated in 5.0.0 has been removed. Use position instead.
  • open which was deprecated in 5.0.0 has been removed. Use opened instead.
  • close which was deprecated in 5.0.0 has been removed. Use closed instead.
  • align-changed which was deprecated in 5.0.0 has been removed. Use positionChanged.

Removes the deletion targets for 6.0.0 from the `material/drawer` entry point.

BREAKING CHANGES:
* The `MatDrawerToggleResult` class has been turned into an type.
* The promise returned from `open`, `close` and `toggle` now resolves with the `MatDrawerToggleResult` type rather than the class.
* `align` which was deprecated in 5.0.0 has been removed. Use `position` instead.
* `open` which was deprecated in 5.0.0 has been removed. Use `opened` instead.
* `close` which was deprecated in 5.0.0 has been removed. Use `closed` instead.
* `align-changed` which was deprecated in 5.0.0 has been removed. Use `positionChanged`.
@crisbeto crisbeto requested a review from mmalerba as a code owner March 6, 2018 10:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 6, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 6, 2018
@mmalerba mmalerba added this to the 6.0 milestone Mar 6, 2018
@mmalerba mmalerba merged commit c1d4666 into angular:master Mar 13, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants