Skip to content

refactor(tooltip): remove 6.0.0 deletion targets #10344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 9, 2018

Removes the deletion targets for 6.0.0 from the material/tooltip entry point.

BREAKING CHANGES:

  • tooltip-position which was deprecated in 5.0.0 has been removed. Use matTooltipPosition instead.
  • The _defaultOptions parameter in the MatTooltip constructor is now required.

Removes the deletion targets for 6.0.0 from the `material/tooltip` entry point.

BREAKING CHANGES:
* `tooltip-position` which was deprecated in 5.0.0 has been removed. Use `matTooltipPosition` instead.
* The `_defaultOptions` parameter in the `MatTooltip` constructor is now required.
@crisbeto crisbeto requested a review from andrewseguin as a code owner March 9, 2018 12:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 9, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 9, 2018
@mmalerba mmalerba merged commit 999cb57 into angular:master Mar 13, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants