Skip to content

fix(drawer): better handling of high contrast mode #10418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

crisbeto
Copy link
Member

Fixes the open drawer blending in with the app background in high contrast mode.

@crisbeto crisbeto added pr: needs review Accessibility This issue is related to accessibility (a11y) labels Mar 14, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner March 14, 2018 10:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Mar 14, 2018
@andrewseguin
Copy link
Contributor

The test failures on this look suspicious - can you look at them?

Fixes the open drawer blending in with the app background in high contrast mode.
@crisbeto crisbeto force-pushed the drawer-high-contrast branch from c0746ec to 1b8ab82 Compare March 19, 2018 20:40
@crisbeto
Copy link
Member Author

I doubt it was from these changes @andrewseguin since they'll only apply if the high contrast media query is matched. I've rebased it just in case.

@josephperrott josephperrott merged commit ff2860f into angular:master Mar 27, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants