Skip to content

Conversation

crisbeto
Copy link
Member

Fixes the offset from the connected position config being ignored by the CdkConnectedOverlay.

Fixes #10449.

Fixes the offset from the connected position config being ignored by the `CdkConnectedOverlay`.

Fixes angular#10449.
@crisbeto crisbeto requested a review from jelbourn as a code owner March 16, 2018 15:03
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 16, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Mar 16, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 16, 2018
@josephperrott josephperrott merged commit 1659004 into angular:master Mar 27, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CdkConnectedOverlay offset from ConnectionPositionPair has no effect
4 participants