Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 39 additions & 6 deletions src/cdk/a11y/focus-monitor/focus-monitor.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
dispatchMouseEvent,
patchElementFocus,
} from '@angular/cdk/testing';
import {Component} from '@angular/core';
import {Component, NgZone} from '@angular/core';
import {ComponentFixture, fakeAsync, flush, inject, TestBed, tick} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {A11yModule} from '../index';
Expand Down Expand Up @@ -212,7 +212,6 @@ describe('FocusMonitor', () => {

expect(buttonElement.classList.length).toBe(0, 'button should not have any focus classes');
}));

});


Expand All @@ -224,7 +223,7 @@ describe('cdkMonitorFocus', () => {
ButtonWithFocusClasses,
ComplexComponentWithMonitorElementFocus,
ComplexComponentWithMonitorSubtreeFocus,
ComplexComponentWithMonitorSubtreeFocusAnfMonitorElementFocus,
ComplexComponentWithMonitorSubtreeFocusAndMonitorElementFocus,
],
}).compileComponents();
});
Expand Down Expand Up @@ -394,15 +393,15 @@ describe('cdkMonitorFocus', () => {
});

describe('complex component with cdkMonitorSubtreeFocus and cdkMonitorElementFocus', () => {
let fixture: ComponentFixture<ComplexComponentWithMonitorSubtreeFocusAnfMonitorElementFocus>;
let fixture: ComponentFixture<ComplexComponentWithMonitorSubtreeFocusAndMonitorElementFocus>;
let parentElement: HTMLElement;
let childElement: HTMLElement;
let focusMonitor: FocusMonitor;

beforeEach(inject([FocusMonitor], (fm: FocusMonitor) => {
focusMonitor = fm;
fixture =
TestBed.createComponent(ComplexComponentWithMonitorSubtreeFocusAnfMonitorElementFocus);
TestBed.createComponent(ComplexComponentWithMonitorSubtreeFocusAndMonitorElementFocus);
fixture.detectChanges();

parentElement = fixture.debugElement.query(By.css('div')).nativeElement;
Expand All @@ -424,6 +423,40 @@ describe('cdkMonitorFocus', () => {
});
});

describe('FocusMonitor observable stream', () => {
let fixture: ComponentFixture<PlainButton>;
let buttonElement: HTMLElement;
let focusMonitor: FocusMonitor;

beforeEach(() => {
TestBed.configureTestingModule({
imports: [A11yModule],
declarations: [
PlainButton,
],
}).compileComponents();
});

beforeEach(inject([FocusMonitor], (fm: FocusMonitor) => {
fixture = TestBed.createComponent(PlainButton);
focusMonitor = fm;
fixture.detectChanges();
buttonElement = fixture.debugElement.nativeElement.querySelector('button');
patchElementFocus(buttonElement);
}));

it('should emit inside the NgZone', fakeAsync(() => {
const spy = jasmine.createSpy('zone spy');
focusMonitor.monitor(buttonElement).subscribe(() => spy(NgZone.isInAngularZone()));
expect(spy).not.toHaveBeenCalled();

buttonElement.focus();
fixture.detectChanges();
tick();
expect(spy).toHaveBeenCalledWith(true);
}));
});


@Component({
template: `<button>focus me!</button>`
Expand Down Expand Up @@ -453,4 +486,4 @@ class ComplexComponentWithMonitorSubtreeFocus {}
@Component({
template: `<div cdkMonitorSubtreeFocus><button cdkMonitorElementFocus></button></div>`
})
class ComplexComponentWithMonitorSubtreeFocusAnfMonitorElementFocus {}
class ComplexComponentWithMonitorSubtreeFocusAndMonitorElementFocus {}
8 changes: 6 additions & 2 deletions src/cdk/a11y/focus-monitor/focus-monitor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ export class FocusMonitor implements OnDestroy {
}

this._setClasses(element, origin);
elementInfo.subject.next(origin);
this._emitOrigin(elementInfo.subject, origin);
this._lastFocusOrigin = origin;
}

Expand All @@ -334,7 +334,11 @@ export class FocusMonitor implements OnDestroy {
}

this._setClasses(element);
elementInfo.subject.next(null);
this._emitOrigin(elementInfo.subject, null);
}

private _emitOrigin(subject: Subject<FocusOrigin>, origin: FocusOrigin) {
this._ngZone.run(() => subject.next(origin));
}

private _incrementMonitoredElementCount() {
Expand Down