Skip to content

refactor(input): improve test speed #10565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2018
Merged

refactor(input): improve test speed #10565

merged 1 commit into from
Apr 6, 2018

Conversation

crisbeto
Copy link
Member

Speeds up the MatInput tests by avoiding recompiling all the various test cases for each test. Also cleans up a lot of boilerplate as a result.

@crisbeto
refactor(input): improve test speed
aa0dde2 
Speeds up the `MatInput` tests by avoiding recompiling all the various test cases for each test. Also cleans up a lot of boilerplate as a result.
@crisbeto crisbeto requested a review from mmalerba as a code owner March 25, 2018 20:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 25, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Apr 2, 2018
@jelbourn jelbourn merged commit fddb40d into angular:master Apr 6, 2018
Longfld pushed a commit to Longfld/material2 that referenced this pull request Apr 6, 2018
@crisbeto @Longfld
refactor(input): improve test speed (angular#10565)
717b4e3 
Speeds up the `MatInput` tests by avoiding recompiling all the various test cases for each test. Also cleans up a lot of boilerplate as a result.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @mmalerba