Skip to content

fix(badge): incorrectly handling rtl #10630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2018
Merged

fix(badge): incorrectly handling rtl #10630

merged 1 commit into from
Apr 5, 2018

Conversation

crisbeto
Copy link
Member

  • Fixes all of the RTL selectors being scoped to the badge itself, rather than a parent, which means that consumers would have to set dir="rtl" on each individual badge.
  • Fixes none of the left/right values being inverted.

@crisbeto
fix(badge): incorrectly handling rtl
6f98023 
* Fixes all of the RTL selectors being scoped to the badge itself, rather than a parent, which means that consumers would have to set `dir="rtl"` on each individual badge.
* Fixes none of the `left`/`right` values being inverted.
@crisbeto crisbeto requested a review from amcdnl as a code owner March 30, 2018 10:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 30, 2018
jelbourn
jelbourn approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Mar 30, 2018
@jelbourn jelbourn merged commit 9c1f8a9 into angular:master Apr 5, 2018
Longfld pushed a commit to Longfld/material2 that referenced this pull request Apr 6, 2018
@crisbeto @Longfld
fix(badge): incorrectly handling rtl (angular#10630)
d651aac 
* Fixes all of the RTL selectors being scoped to the badge itself, rather than a parent, which means that consumers would have to set `dir="rtl"` on each individual badge.
* Fixes none of the `left`/`right` values being inverted.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot