Skip to content

build: fix dashboard compilation errors #11066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2018

Conversation

crisbeto
Copy link
Member

Fixes errors when trying to build and deploy the dashboard. Note that I had to switch to the latest stable version of Material and the CDK, because some of our dependencies don't support Angular 6 yet.

Fixes errors when trying to build and deploy the dashboard. Note that I had to switch to the latest stable version of Material and the CDK, because some of our dependencies don't support Angular 6 yet.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 29, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This whole dashboard probably needs some real attention

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 30, 2018
@josephperrott josephperrott removed the request for review from devversion May 1, 2018 21:38
@josephperrott josephperrott merged commit 340b0b2 into angular:master May 1, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants