fix(stepper): handle keyboard interactions if direction changes after init #11067
Conversation
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
src/cdk/stepper/stepper.ts
Outdated
| .withHorizontalOrientation(this._layoutDirection()) | ||
| .withVerticalOrientation(this._orientation === 'vertical'); | ||
|
|
||
| (this._dir ? this._dir.change.asObservable() : obaservableOf()) |
There was a problem hiding this comment.
@crisbeto can you remove the asObservable here? There are places in Google where people provide a fake Directionality with just an Observable as change instead of a Subject
(the real API should really be an Observable as well)
There was a problem hiding this comment.
Done. I had to do it initially, because TS was complaining. I've changed it to cast to an observable instead.
… init Currently the stepper checks for its direction once on init, in order to configure its keyboard control direction, however this doesn't account for the cases where the direction changes dynamically afterwards. These changes ensure that the keyboard controls are correct in case the layout direction changes.
crisbeto
force-pushed
the
stepper-dir-change
branch
from
15560a1 to
87db138
Compare
… init (angular#11067) Currently the stepper checks for its direction once on init, in order to configure its keyboard control direction, however this doesn't account for the cases where the direction changes dynamically afterwards. These changes ensure that the keyboard controls are correct in case the layout direction changes.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently the stepper checks for its direction once on init, in order to configure its keyboard control direction, however this doesn't account for the cases where the direction changes dynamically afterwards. These changes ensure that the keyboard controls are correct in case the layout direction changes.