Skip to content

Conversation

Gusachenko
Copy link
Contributor

Fix for demo-sidenav behaviour after the drawer opened . For correct set focus on input after #start sidenav was opened.

Fix for `demo-sidenav` behaviour after `drawer` opened . For correct set focus on `INPUT` after  `#start` sidenav was opened.
@Gusachenko Gusachenko requested a review from mmalerba as a code owner May 8, 2018 15:03
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 8, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 8, 2018
@ngbot
Copy link

ngbot bot commented May 8, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    pending status "continuous-integration/travis-ci/pr" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 853b04c into angular:master May 8, 2018
@Gusachenko Gusachenko deleted the sidenav-demo-fix-event-opened branch May 8, 2018 17:03
@Gusachenko Gusachenko restored the sidenav-demo-fix-event-opened branch May 8, 2018 17:05
@Gusachenko Gusachenko deleted the sidenav-demo-fix-event-opened branch May 8, 2018 17:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants