perf(sidenav): avoid hitting zone continuously when using autosize option #11231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…tion Avoids hitting the `NgZone` infinitely when using the `autosize` option. Fixes angular#11215.
crisbeto
force-pushed
the
11215/sidenav-autosize
branch
from
a23973f to
ba0d0cd
Compare
crisbeto
changed the title
mmalerba
approved these changes
May 8, 2018
mmalerba
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
May 14, 2018
…tion (angular#11231) Avoids hitting the `NgZone` infinitely when using the `autosize` option. Fixes angular#11215.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 4, 2018
Fixes the sidenav going into an infinite change detection loop when using the `autosize` option. Initially this was fixed in angular#11231, but it got reintroduced in angular#11986 where we started comparing `0` against `null` which always evaluates to true. Fixes angular#11215.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 4, 2018
Fixes the sidenav going into an infinite change detection loop when using the `autosize` option. Initially this was fixed in angular#11231, but it got reintroduced in angular#11986 where we started comparing `0` against `null` which always evaluates to true. Fixes angular#11215.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids hitting the
NgZoneinfinitely when using theautosizeoption. Moves some properties around and switches to only re-entering the zone when something changes.Fixes #11215.