Skip to content

Conversation

andrewseguin
Copy link
Contributor

Continuation of #10982 - looks like more constructors need to be added. Tested in a separate CLI project to confirm this is the final changes necessary.

Fixes #9329

@andrewseguin andrewseguin requested a review from jelbourn May 9, 2018 22:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 9, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels May 9, 2018
@jelbourn jelbourn merged commit 8e7dd80 into angular:master May 10, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request May 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] Does not work when targetting ES6
3 participants