Skip to content

feat(tree): Add support for trackBy #11267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2018
Merged

feat(tree): Add support for trackBy #11267

merged 1 commit into from
May 11, 2018

Conversation

stasmaxymov
Copy link
Contributor

Add trackBy support to cdk-tree component

@stasmaxymov
feat(tree): Add support for trackBy
9c5fa98 
Add trackBy support improve performance
@stasmaxymov stasmaxymov requested a review from tinayuangao as a code owner May 10, 2018 15:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 10, 2018
tinayuangao
tinayuangao approved these changes May 10, 2018
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for adding this

@tinayuangao tinayuangao added target: minor This PR is targeted for the next minor release pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 10, 2018
@jelbourn jelbourn merged commit ff34dac into angular:master May 11, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@tinayuangao tinayuangao tinayuangao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stasmaxymov @tinayuangao @jelbourn @googlebot