Skip to content

build: fix tests crashing IE test runs #11287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2018
Merged

build: fix tests crashing IE test runs #11287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/cdk/overlay/position/flexible-connected-position-strategy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,13 @@ describe('FlexibleConnectedPositionStrategy', () => {
originY: 'bottom'
}]);

// Needs to be in the DOM for IE not to throw an "Unspecified error".
document.body.appendChild(origin.nativeElement);
attachOverlay({positionStrategy});

expect(() => attachOverlay({positionStrategy})).toThrow();

document.body.removeChild(origin.nativeElement);
});

it('should not throw when trying to apply after being disposed', () => {
Expand All @@ -82,10 +87,14 @@ describe('FlexibleConnectedPositionStrategy', () => {
originY: 'bottom'
}]);

// Needs to be in the DOM for IE not to throw an "Unspecified error".
document.body.appendChild(origin.nativeElement);
attachOverlay({positionStrategy});
overlayRef.dispose();

expect(() => positionStrategy.apply()).not.toThrow();

document.body.removeChild(origin.nativeElement);
});

it('should not throw when trying to re-apply the last position after being disposed', () => {
Expand All @@ -99,10 +108,14 @@ describe('FlexibleConnectedPositionStrategy', () => {
originY: 'bottom'
}]);

// Needs to be in the DOM for IE not to throw an "Unspecified error".
document.body.appendChild(origin.nativeElement);
attachOverlay({positionStrategy});
overlayRef.dispose();

expect(() => positionStrategy.reapplyLastPosition()).not.toThrow();

document.body.removeChild(origin.nativeElement);
});

describe('without flexible dimensions and pushing', () => {
Expand Down Expand Up @@ -1604,6 +1617,7 @@ describe('FlexibleConnectedPositionStrategy', () => {
});

afterEach(() => {
document.body.removeChild(originElement);
positionStrategy.dispose();
});

Expand Down