fix: prevent nested expansion panels from registering to the same accordion #11342
Conversation
josephperrott
added
the
target: patch
googlebot
added
the
cla: yes
src/cdk/accordion/accordion.spec.ts
Outdated
| class NestedItems { | ||
| @ViewChild('outerItem') outerItem: CdkAccordionItem; | ||
| @ViewChild('innerItem') innerItem: CdkAccordionItem; | ||
| } |
There was a problem hiding this comment.
Needs a new line at the end of the file.
| providers: [ | ||
| // Provide CdkAccordion as undefined to prevent nested accordion items from registering | ||
| // to the same accordion. | ||
| {provide: CdkAccordion, useValue: undefined}, |
There was a problem hiding this comment.
TIL that you can do this. I had to do something similar on the menu, but I ended up adding a provider and having the items register themselves with it.
crisbeto
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
@josephperrott seems like there are some lint warnings. |
josephperrott
force-pushed
the
expansion-panel
branch
from
4c0e1cf to
e584569
Compare
josephperrott
force-pushed
the
expansion-panel
branch
from
e584569 to
ef6fa95
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #11242