Skip to content

Conversation

crisbeto
Copy link
Member

Disables all of the CSS-based animations in the form field when using the NoopAnimationsModule.

Relates to #10590.

@crisbeto crisbeto requested a review from mmalerba as a code owner May 16, 2018 20:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 16, 2018
'[class.ng-valid]': '_shouldForward("valid")',
'[class.ng-invalid]': '_shouldForward("invalid")',
'[class.ng-pending]': '_shouldForward("pending")',
'[class._mat-animation-noopable]': '!_animationsEnabled',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the class name we used in other components? The _ seems unnecessary

Copy link
Member Author

@crisbeto crisbeto May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I kept it for consistency with the other components, but I'm not sure where the underscore comes from @josephperrott.

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 21, 2018
@ngbot
Copy link

ngbot bot commented May 21, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label May 21, 2018
@mmalerba
Copy link
Contributor

@crisbeto needs rebase

@crisbeto crisbeto force-pushed the form-field-noop-animations branch from 81bb4f1 to 935c6ed Compare May 24, 2018 05:15
@crisbeto
Copy link
Member Author

Rebased.

@mmalerba
Copy link
Contributor

@crisbeto looks like tests are failing

Disables all of the CSS-based animations in the form field when using the `NoopAnimationsModule`.

Relates to angular#10590.
@crisbeto crisbeto force-pushed the form-field-noop-animations branch from 935c6ed to d042b15 Compare May 24, 2018 18:35
@crisbeto
Copy link
Member Author

CI failures should be sorted out now.

@mmalerba mmalerba merged commit 9062640 into angular:master May 25, 2018
mmalerba pushed a commit that referenced this pull request May 29, 2018
…le (#11371)

Disables all of the CSS-based animations in the form field when using the `NoopAnimationsModule`.

Relates to #10590.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants