Skip to content

fix(tabs): disable all animations when using NoopAnimationsModule #11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2019
Merged

fix(tabs): disable all animations when using NoopAnimationsModule #11395

merged 1 commit into from
Jun 13, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 17, 2018 •
edited
Loading

Currently some animations in the tab components don't get disabled, when using the NoopAnimationsModule, because they don't go through the Angular animations. These changes ensure that everything will be disabled.

Relates to #10590.

@crisbeto crisbeto requested a review from andrewseguin as a code owner May 17, 2018 20:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 17, 2018
@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 29, 2018
@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch 2 times, most recently from e28cc3d to b9b6f76 Compare June 5, 2018 11:17
@ngbot
Copy link

ngbot bot commented Jun 7, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@josephperrott josephperrott added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Jun 26, 2018
@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch from b9b6f76 to 470d083 Compare June 28, 2018 05:50
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jun 28, 2018
@ngbot
Copy link

ngbot bot commented Jul 11, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

1 similar comment
@ngbot
Copy link

ngbot bot commented Jul 11, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch from 470d083 to 2af65ed Compare July 14, 2018 12:20
@devversion devversion mentioned this pull request Aug 24, 2018
Closed
@jelbourn
Copy link
Member

@crisbeto github shows this PR as having no conflicts, but our presubmit script thinks it does. Could you rebase it?

@crisbeto
Copy link
Member Author

Done.

@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch from 2af65ed to 95d16f1 Compare August 26, 2018 16:51
@ngbot
Copy link

ngbot bot commented Sep 11, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch from 95d16f1 to 529727b Compare September 13, 2018 19:06
@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch from 529727b to a7e3a00 Compare November 21, 2018 22:05
@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch from a7e3a00 to d2f007a Compare December 16, 2018 21:16
@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch 2 times, most recently from 695af66 to 11f35c4 Compare January 24, 2019 22:13
@josephperrott
Copy link
Member

@crisbeto can you update the golden APIs for this PR?

@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch from 11f35c4 to 1650562 Compare March 6, 2019 17:39
@crisbeto
Copy link
Member Author

crisbeto commented Mar 6, 2019

Done @josephperrott.

@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch from 1650562 to 3a5ecce Compare April 5, 2019 20:55
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue labels May 30, 2019
@crisbeto
fix(tabs): disable all animations when using NoopAnimationsModule
aa816be 
Currently some animations in the tab components don't get disabled, when using the `NoopAnimationsModule`, because they don't go through the Angular animations. These changes ensure that everything will be disabled.

Fixes angular#10590.
@crisbeto crisbeto force-pushed the 10590/tabs-noop-animations branch from 3a5ecce to aa816be Compare June 11, 2019 05:29
@mmalerba mmalerba merged commit 27a08cc into angular:master Jun 13, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@crisbeto @RudolfFrederiksen
fix(tabs): disable all animations when using NoopAnimationsModule (an…
3a6103b 
…gular#11395)

Currently some animations in the tab components don't get disabled, when using the `NoopAnimationsModule`, because they don't go through the Angular animations. These changes ensure that everything will be disabled.

Fixes angular#10590.
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
@crisbeto @andrewseguin
fix(tabs): disable all animations when using NoopAnimationsModule (#1…
91326e9 
…1395)

Currently some animations in the tab components don't get disabled, when using the `NoopAnimationsModule`, because they don't go through the Angular animations. These changes ensure that everything will be disabled.

Fixes #10590.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crisbeto @jelbourn @josephperrott @andrewseguin @googlebot @mmalerba