Skip to content

fix(slider): disable animations when using NoopAnimationsModule #11422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2018
Merged

fix(slider): disable animations when using NoopAnimationsModule #11422

merged 1 commit into from
May 23, 2018

Conversation

crisbeto
Copy link
Member

Fixes the slider animations not being disabled when the consumer uses the NoopAnimationsModule.

Relates to #10590.

@crisbeto crisbeto requested a review from mmalerba as a code owner May 20, 2018 14:45
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 20, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 21, 2018
@ngbot
Copy link

ngbot bot commented May 21, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

mmalerba
mmalerba reviewed May 21, 2018
View reviewed changes
src/lib/slider/slider.ts
@Optional() private _dir: Directionality,
@Attribute('tabindex') tabIndex: string) {
@Attribute('tabindex') tabIndex: string,
@Optional() @Inject(ANIMATION_MODULE_TYPE) public _animationMode?: string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave comment to remove ? at next major

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label May 21, 2018
@crisbeto
fix(slider): disable animations when using NoopAnimationsModule
31bcbc2 
Fixes the slider animations not being disabled when the consumer uses the `NoopAnimationsModule`.

Relates to angular#10590.
@crisbeto crisbeto force-pushed the 11408/slider-noop-animatons branch from 55c586f to 31bcbc2 Compare May 22, 2018 17:47
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 22, 2018
@mmalerba mmalerba merged commit cf17ef7 into angular:master May 23, 2018
mmalerba pushed a commit that referenced this pull request May 24, 2018
@crisbeto @mmalerba
fix(slider): disable animations when using NoopAnimationsModule (#11422)
5aeeeb5 
Fixes the slider animations not being disabled when the consumer uses the `NoopAnimationsModule`.

Relates to #10590.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @mmalerba @googlebot