Skip to content

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Jun 7, 2018

Convert tabs demo into examples that can be used on the docs site

@andrewseguin andrewseguin requested a review from amcdnl as a code owner June 7, 2018 22:07
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 7, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<mat-tab-group>
<mat-tab label="First">
<ng-template matTabContent>
Content 1 - Loaded: {{ getTimeLoaded(1) | date:'medium' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omit spaces in braces (here and elsewhere)

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jun 7, 2018
@andrewseguin andrewseguin merged commit 9cfc32f into angular:master Jun 8, 2018
@andrewseguin andrewseguin added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Jun 8, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants