Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 8, 2018

Fixes the page size selector value being truncated if the default form field appearance is set to outline or fill.

Fixes #11681.

… fill appearances

Fixes the page size selector value being truncated if the default form field appearance is set to `outline` or `fill`.

Fixes angular#11681.
@crisbeto crisbeto requested a review from andrewseguin as a code owner June 8, 2018 20:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 8, 2018
margin: $mat-paginator-items-per-page-label-margin;
}

.mat-paginator-page-size-select {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewseguin an alternate approach to solve this would be to lock down the form field to always have appearance="standard".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how that fits into the spec, but it seems that is valid. However, in the case of the issue it sounds like they do want the different style; I suppose we should support it

@andrewseguin andrewseguin added target: patch This PR is targeted for the next patch release pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 8, 2018
@ngbot
Copy link

ngbot bot commented Jun 8, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit 255c10a into angular:master Jun 15, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
… fill appearances (#11722)

Fixes the page size selector value being truncated if the default form field appearance is set to `outline` or `fill`.

Fixes #11681.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table pagination dropdown cuts off pagesize value with new "fill" and "outline" appearances
4 participants