Skip to content

Conversation

crisbeto
Copy link
Member

Based on the accessibility guidelines, multi-selection lists should support selecting/deselecting all using ctrl+a.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2018
[Based on the accessibility guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox), multi-selection lists should support selecting/deselecting all using ctrl+a.
@crisbeto crisbeto force-pushed the multi-select-ctrl-a branch from 512ef76 to 4413893 Compare June 19, 2018 21:12
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 19, 2018
@josephperrott josephperrott merged commit d5de711 into angular:master Jun 29, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants