fix(overlay): don't dispatch key events to overlays that don't handle them #11810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them Currently we dispatch keydown events to the most-recently-opened overlay, however this means that an overlay that doesn't handle keyboard events will end up blocking the events for all the overlays under it. These changes add a check that will skip overlays that don't subscribe to keydown events when determining which overlay to dispatch the event to. Fixes angular#11807.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
Jun 29, 2018
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we dispatch keydown events to the most-recently-opened overlay, however this means that an overlay that doesn't handle keyboard events will end up blocking the events for all the overlays under it. These changes add a check that will skip overlays that don't subscribe to keydown events when determining which overlay to dispatch the event to.
Fixes #11807.