Skip to content

fix(GlobalPositionStrategy): justifyContent center ignored when direction is RTL #11877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2018
Merged

fix(GlobalPositionStrategy): justifyContent center ignored when direction is RTL #11877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f8e2be
fix(GlobalPositionStrategy): justifyContent center ignored when direc…
Jun 21, 2018
baf4fec
fix for commit 1f8e2be70718fbac8da54a92e3f44262d273bd7e
Jun 21, 2018
51eb228
fix for commit 1f8e2be70718fbac8da54a92e3f44262d273bd7e
Jun 21, 2018
4ad21e1
revert to baf4fec03567a706d76f2ae6413ea5494a264033
Jun 24, 2018
bc2179e
change the logic to what @crisbeto wanted
Jun 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/cdk/overlay/position/global-position-strategy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,20 @@ describe('GlobalPositonStrategy', () => {
expect(elementStyle.height).toBe('300px');
});

it('should center the element in RTL', () => {
attachOverlay({
direction: 'rtl',
positionStrategy: overlay.position()
.global()
.centerHorizontally()
.centerVertically()
});

const parentStyle = (overlayRef.overlayElement.parentNode as HTMLElement).style;
expect(parentStyle.justifyContent).toBe('center');
expect(parentStyle.alignItems).toBe('center');
});

it('should invert `justify-content` when using `left` in RTL', () => {
attachOverlay({
positionStrategy: overlay.position().global().left('0'),
Expand Down
2 changes: 2 additions & 0 deletions src/cdk/overlay/position/global-position-strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ export class GlobalPositionStrategy implements PositionStrategy {

if (config.width === '100%') {
parentStyles.justifyContent = 'flex-start';
} else if (this._justifyContent === 'center') {
parentStyles.justifyContent = 'center';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the indentation here is too much.

} else if (this._overlayRef.getConfig().direction === 'rtl') {
// In RTL the browser will invert `flex-start` and `flex-end` automatically, but we
// don't want that because our positioning is explicitly `left` and `right`, hence
Expand Down