Skip to content

fix(button-toggle): parent margin and padding being propagated to underlying button #11993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2018
Merged

fix(button-toggle): parent margin and padding being propagated to underlying button #11993

merged 1 commit into from
Jul 10, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 30, 2018 •
edited
Loading

Fixes the button inside a button toggle inheriting the margin and padding from its parent.

Fixes #11976.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jun 30, 2018
@crisbeto crisbeto requested a review from tinayuangao as a code owner June 30, 2018 07:20
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 30, 2018
@crisbeto
fix(button-toggle): parent margin and padding being propagated to und…
26ee7da 
…erlying button

Fixes the button inside a button toggle inheriting the margin and padding from its parent.

Fixes angular#11976.
@crisbeto crisbeto force-pushed the 11976/button-toggle-margin branch from 17f0ee5 to 26ee7da Compare June 30, 2018 11:38
@crisbeto crisbeto changed the title fix(button-toggle): parent margin being propagated to underlying button fix(button-toggle): parent margin and padding being propagated to underlying button Jun 30, 2018
@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 2, 2018
josephperrott
josephperrott approved these changes Jul 2, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 3bf10f9 into angular:master Jul 10, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
fix(button-toggle): parent margin and padding being propagated to und…
837b936 
…erlying button (#11993)

Fixes the button inside a button toggle inheriting the margin and padding from its parent.

Fixes #11976.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug mat-button-toggle: button inherit margin from class in mat-button-toggle
5 participants
@crisbeto @josephperrott @jelbourn @googlebot @tinayuangao