Skip to content

fix(form-field): placeholder not hiding if -webkit-text-fill-color is used #12076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2018
Merged

fix(form-field): placeholder not hiding if -webkit-text-fill-color is used #12076

merged 1 commit into from
Jul 11, 2018

Conversation

devversion
Copy link
Member

If developers use -webkit-text-fill-color to change the color of the placeholder and label, the actual "native" placeholder won't be invisible because -webkit-text-fill-color overwrites color: transparent.

Fixes #12074

@devversion devversion added the target: patch This PR is targeted for the next patch release label Jul 5, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 5, 2018
crisbeto
crisbeto approved these changes Jul 5, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 5, 2018
@ngbot

This comment has been minimized.

Sign in to view
@devversion
fix(form-field): placeholder not hiding if -webkit-text-fill-color …
0ffb27a 
…is used

If developers use `-webkit-text-fill-color` to change the color of the placeholder and label, the actual "native" placeholder won't be invisible because `-webkit-text-fill-color` overwrites `color: transparent`.

Fixes angular#12074
@devversion devversion force-pushed the fix/form-field-placeholder-webkit-text-fill branch from bbb11ae to 0ffb27a Compare July 9, 2018 18:03
jelbourn
jelbourn approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit cc5dfb8 into angular:master Jul 11, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@devversion @victoriaaa234
fix(form-field): placeholder not hiding if -webkit-text-fill-color …
fd73d52 
…is used (#12076)

If developers use `-webkit-text-fill-color` to change the color of the placeholder and label, the actual "native" placeholder won't be invisible because `-webkit-text-fill-color` overwrites `color: transparent`.

Fixes #12074
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@crisbeto crisbeto

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Label and placeholder always appear on Input when parent has 'webkit-text-fill-color' property.
5 participants
@devversion @jelbourn @crisbeto @googlebot @mmalerba