Skip to content

Conversation

devversion
Copy link
Member

Depending on the timing for building the assets and building the ESM output (kind of randomly), building the Material package will result in NGC failures.

This happens when running the material:build-no-bundles task (e.g. unit testing; serving the dev-app) because the assets are built in parallel with the ESM output.

Also removes a duplicated function in the package-tools.

0e0999b506a3e8b427cc327645c84fbf

@devversion devversion requested a review from jelbourn as a code owner July 8, 2018 11:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 8, 2018
* Depending on the timing for building the assets and building the ESM output (kind of randomly), building the Material package will result in NGC failures. This happens when running the `material:build-no-bundles` task (e.g. unit testing; serving the dev-app) because the assets are built in parallel with the ESM output.
* Removes a duplicated function in the package-tools.
@devversion devversion force-pushed the build/fix-random-ngc-resolve-failures branch from 280a1ac to 2e66b65 Compare July 9, 2018 18:04
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2018
@jelbourn jelbourn merged commit f315e3e into angular:master Jul 11, 2018
CaerusKaru added a commit to angular/flex-layout that referenced this pull request Jul 25, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
* Depending on the timing for building the assets and building the ESM output (kind of randomly), building the Material package will result in NGC failures. This happens when running the `material:build-no-bundles` task (e.g. unit testing; serving the dev-app) because the assets are built in parallel with the ESM output.
* Removes a duplicated function in the package-tools.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants