Skip to content

fix(sidenav): move @Input to getter/setter instead of private field #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(sidenav): move @Input to getter/setter instead of private field #1245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/sidenav/sidenav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export class MdSidenav {
@Input() mode: 'over' | 'push' | 'side' = 'over';

/** Whether the sidenav is opened. */
@Input('opened') @BooleanFieldValue() private _opened: boolean = false;
private _opened: boolean = false;

/** Event emitted when the sidenav is being opened. Use this to synchronize animations. */
@Output('open-start') onOpenStart = new EventEmitter<void>();
Expand All @@ -75,6 +75,7 @@ export class MdSidenav {
* Whether the sidenav is opened. We overload this because we trigger an event when it
* starts or end.
*/
@Input() @BooleanFieldValue()
get opened(): boolean { return this._opened; }
set opened(v: boolean) {
this.toggle(v);
Expand Down