fix(): remove all async/waiting from the sidenav specs. #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
hansl
force-pushed
the
sidenav-fix
branch
5 times, most recently
from
a1b7111 to
89eb7be
Compare
|
I also moved Chrome Beta to optionals. SauceLabs can't start it up apparently. |
|
|
||
| function endSidenavTransition(fixture: ComponentFixture) { | ||
| let sidenav: any = fixture.debugElement.query(By.directive(MdSidenav)).componentInstance; | ||
| (<any>sidenav).onTransitionEnd_({ |
There was a problem hiding this comment.
I think this will fail on dart (calling a private method).
|
LGTM |
andrewseguin
added a commit
to andrewseguin/components
that referenced
this pull request
Oct 15, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to separate transitions from sidenav because we don't actually remove the hook listener and as such
onTransitionEnd_could get called from the browser. There's a bunch of override methods missing from the Angular testing, and we can't wait on their implementation.This will become moot with
ngAnimate, so I think it's fine.