fix(expansion): respect parent accordion hideToggle binding #12725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes that the expansion panels no longer respect the bindings of a parent `<mat-accordion>`. (this has been accidentally changes in angular#6529) * Fixes that the expansion panel does not re-render if the `[hideToggle]` binding is set on the accordion. * Removes the unused `_getHideToggle` method. This method is no longer used because the panel header directly accesses the panel through DI.
devversion
added
the
target: patch
googlebot
added
the
cla: yes
crisbeto
approved these changes
Aug 18, 2018
| /** Determines whether the expansion panel should have spacing between it and its siblings. */ | ||
| _hasSpacing(): boolean { | ||
| if (this.accordion) { | ||
| // We don't need to subscribe to the `stateChanges` of the parent accordion because each time |
There was a problem hiding this comment.
This seems like a weird place to put this comment, but I don't have any better suggestions.
crisbeto
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Aug 29, 2018
* Fixes that the expansion panels no longer respect the bindings of a parent `<mat-accordion>`. (this has been accidentally changes in #6529) * Fixes that the expansion panel does not re-render if the `[hideToggle]` binding is set on the accordion. * Removes the unused `_getHideToggle` method. This method is no longer used because the panel header directly accesses the panel through DI.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<mat-accordion>. (this has been accidentally changes in feat(expansion-panel): add the ability to disable an expansion panel #6529)[hideToggle]binding is updated on the accordion._getHideTogglemethod. This method is no longer used because the panel header directly accesses the panel through DI.