chore: make publish version+branch check support minor and patch #12910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
reviewed
Aug 30, 2018
| if (versionType === 'major') { | ||
| expectedBranch = 'master'; | ||
| } else if (versionType === 'minor') { | ||
| expectedBranch = `${major}.x.x`; |
There was a problem hiding this comment.
Just a question: right now isn't the branch always 6.x? instead of 6.x.x?
devversion
approved these changes
Aug 30, 2018
devversion
added
pr: lgtm
action: merge
jelbourn
force-pushed
the
publish-version-check
branch
from
d722b6a to
89563dd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@devversion I made this work for now, but it will need an extra bit of knowledge after we publish v7. At that point,
masterwill represent the nextminorrelease, so we need to allow that if a corresponding minor branch (e.g.7.x.x) does not yet exist on upstream (directly checkinggit@github.com:angular/material2.git).