Skip to content

fix(form-field): don't set up mutation observer on non-outline appearances #12976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2018
Merged

fix(form-field): don't set up mutation observer on non-outline appearances #12976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/cdk/observers/observe-content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,7 @@ export class CdkObserveContent implements AfterContentInit, OnDestroy {
get disabled() { return this._disabled; }
set disabled(value: any) {
this._disabled = coerceBooleanProperty(value);
if (this._disabled) {
this._unsubscribe();
} else {
this._subscribe();
}
this._disabled ? this._unsubscribe() : this._subscribe();
}
private _disabled = false;

Expand Down
1 change: 1 addition & 0 deletions src/lib/form-field/form-field.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
read if it comes before the control in the DOM. -->
<label class="mat-form-field-label"
(cdkObserveContent)="updateOutlineGap()"
[cdkObserveContentDisabled]="appearance != 'outline'"
[id]="_labelId"
[attr.for]="_control.id"
[attr.aria-owns]="_control.id"
Expand Down