Skip to content

docs(typography): add css classes to typography guide #13154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

crisbeto
Copy link
Member

Replaces the bullet list in the typography docs with a table that also shows the CSS classes that each of the breakpoints maps to.

Fixes #13151.

@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 16, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 16, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we point this document to the archived version of the spec now?

Replaces the bullet list in the typography docs with a table that also shows the CSS classes that each of the breakpoints maps to.

Fixes angular#13151.
@crisbeto crisbeto force-pushed the 13151/typography-classes-docs branch from 93f6b15 to 8bd451b Compare September 17, 2018 15:59
@crisbeto
Copy link
Member Author

Done.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 17, 2018
@jelbourn jelbourn merged commit 68c45ad into angular:master Sep 17, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update typography documentation with names of css classes
3 participants