docs(table): fix typo in MatRowDef description #13170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Sep 17, 2018
| @@ -49,7 +49,7 @@ export class MatFooterRowDef extends _CdkFooterRowDef {} | |||
|
|
|||
| /** | |||
| * Data row definition for the mat-table. | |||
| * Captures the footer row's template and other footer properties such as the columns to display and | |||
| * Captures the data row's template and other properties such as the columns to display and | |||
There was a problem hiding this comment.
I don't think this needs the "data" either, it can be just "Captures the row's template...".
There was a problem hiding this comment.
@crisbeto it can but I think it's more accurate to add "data" since first sentence states that it's "Data row definition for the mat-table."
There was a problem hiding this comment.
Also it's clearer when described this way that it only relates to normal data rows and not header or footer rows.
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.